Skip to content

Conversation

@akinross
Copy link
Collaborator

@akinross akinross commented Dec 1, 2025

No description provided.

@akinross akinross added the jira-sync Sync this issue to Jira label Dec 1, 2025
@github-actions github-actions bot changed the title Migrate aci l2 interface policy Migrate aci l2 interface policy (DCNE-611) Dec 1, 2025
shrsr
shrsr previously approved these changes Dec 4, 2025
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 5, 2025
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 8, 2025
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Dec 11, 2025
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akinross akinross dismissed stale reviews from sajagana, gmicol, samiib, and shrsr via f041c17 December 18, 2025 12:14
@akinross akinross force-pushed the migrate_aci_l2_interface_policy branch from bc06170 to f041c17 Compare December 18, 2025 12:14
shrsr
shrsr previously approved these changes Dec 18, 2025
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Dec 19, 2025
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

samiib
samiib previously approved these changes Jan 6, 2026
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Jan 6, 2026
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* `name_alias` (nameAlias) - (string) The name alias of the L2 Interface Policy object. This attribute is supported in ACI versions: 2.2(1k) and later.
* `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation.
* `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object.
* `qinq` (qinq) - (string) The QinQ port type of the L2 Interface Policy object. This attribute is supported in ACI versions: 2.2(1k) and later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be q_in_q?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally kept qinq to avoid rename, but have changed it now.

@akinross akinross dismissed stale reviews from gmicol, samiib, sajagana, and shrsr via 13535e4 January 19, 2026 07:47
@akinross akinross force-pushed the migrate_aci_l2_interface_policy branch from 13535e4 to d90a606 Compare January 19, 2026 07:51
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira-sync Sync this issue to Jira

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants