Add logic for static custom type (DCNE-632) #1437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attribute for the verification
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
requested changes
Jan 9, 2026
gen/templates/custom_type.go.tmpl
Outdated
| @@ -1,3 +1,7 @@ | |||
| // Code generated by "gen/generator.go"; DO NOT EDIT. | |||
Collaborator
There was a problem hiding this comment.
split this change to split PR to reduce changes and quick review
| {{.ResourceClassName}}{{ .Name }} types.String `tfsdk:"{{overwriteProperty .PkgName .SnakeCaseName $.Definitions}}"` | ||
| {{- else if .HasCustomType}} | ||
| {{ .Name }} customTypes.{{.ResourceClassName}}{{.Name}}StringValue `tfsdk:"{{overwriteProperty .PkgName .SnakeCaseName $.Definitions}}"` | ||
| {{ .Name }} customTypes.{{- if .StaticCustomType}}{{.StaticCustomType}}{{else}}{{.ResourceClassName}}{{.Name}}{{- end}}StringValue `tfsdk:"{{overwriteProperty .PkgName .SnakeCaseName $.Definitions}}"` |
Collaborator
There was a problem hiding this comment.
missing legacy attribute support and changes
| name: "131" | ||
| custom_type: | ||
| ip: fe80::0002 | ||
| static_custom_type: |
Collaborator
There was a problem hiding this comment.
did you check for all other attributes in other resources where ipv6 types should be used?
Collaborator
|
what is the impact during provider upgrade? |
sajagana
force-pushed
the
static_custom_type
branch
from
ab53192 to
c5ba742
Compare
sajagana
force-pushed
the
static_custom_type
branch
from
c5ba742 to
33df5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.