Added aci_virtual_ip_address resource (DCNE-45)#1442
Closed
sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
Closed
Added aci_virtual_ip_address resource (DCNE-45)#1442sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
sajagana wants to merge 5 commits intoCiscoDevNet:masterfrom
Conversation
…attribute for the verification
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
shrsr
requested changes
Feb 2, 2026
docs/resources/virtual_ip_address.md
Outdated
|
|
||
| * `parent_dn` - (string) The distinguished name (DN) of the parent object, possible resources: | ||
| - [aci_application_epg](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/application_epg) ([fvAEPg](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/fvAEPg/overview)) | ||
| * `ip` (addr) - (string) The L4-L7 Virtual IP Address of the Virtual IP Address object. |
Collaborator
There was a problem hiding this comment.
The description sounds redundant..
Could we change it to -> The L4-L7 Virtual IP Address for this object.
|
|
||
| * `parent_dn` - (string) The distinguished name (DN) of the parent object, possible resources: | ||
| - [aci_application_epg](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/application_epg) ([fvAEPg](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/fvAEPg/overview)) | ||
| * `ip` (addr) - (string) The L4-L7 Virtual IP Address of the Virtual IP Address object. |
Collaborator
There was a problem hiding this comment.
The description sounds redundant..
Could we change it to -> The L4-L7 Virtual IP Address for this object.
samiib
reviewed
Feb 3, 2026
|
|
||
| var _ basetypes.StringTypable = RoundedPercentageStringType{} | ||
|
|
||
| type RoundedPercentageStringType struct { |
Collaborator
There was a problem hiding this comment.
Is RoundedPercentageStringType being used anywhere? I can only see the IPV6 custom type being used in this PR but I may have missed something.
akinross
requested changes
Feb 5, 2026
| unicast_routing: "yes" | ||
| virtual_mac_address: 00:22:BD:F8:19:FB | ||
| custom_type: | ||
| link_local_ipv6_address: fe80::0002 |
Collaborator
There was a problem hiding this comment.
should we also test the full form ipv6 address? now it is only a :: form
Collaborator
Author
|
Created alternate PR: #1455, to avoid conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.