Skip to content

Enhanced to support seleniumbox #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhanced to support seleniumbox #52

wants to merge 2 commits into from

Conversation

@vijperum
Copy link

Added support for seleniumbox
devices

an example for seleniumbox implementation

seleniumbox:
    type: browser
    connections:
        webdriver:
            class: genie.webdriver.connectors.WebDriverConnector
            driver: "any"
            version: "any"
            testname: "TEST"
            token: "" #seleniumbox token

https://seleniumbox.cisco.com/

@vijperum vijperum requested a review from a team as a code owner August 10, 2024 16:30
@vijperum vijperum requested review from Taarini and domachad August 10, 2024 16:30
Taarini
Taarini requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@Taarini Taarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add UT for the changes

@vijperum
Copy link
Author

Ran 7 tests in 4.152s

OK

@vijperum vijperum requested a review from Taarini August 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domachad domachad Awaiting requested review from domachad domachad is a code owner automatically assigned from CiscoTestAutomation/pyats-genie-devs

@Taarini Taarini Awaiting requested review from Taarini

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vijperum @Taarini