-
Notifications
You must be signed in to change notification settings - Fork 36
[TAN-6031]- add Accessibility Inputs to SurveyQuestion widget #12740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[TAN-6031]- add Accessibility Inputs to SurveyQuestion widget #12740
Conversation
|
…ey-question-widget
luucvanderzee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to remove the changes from the users_spec file. Other than that everything looks good!
back/spec/acceptance/users_spec.rb
Outdated
|
|
||
| before do | ||
| header 'Content-Type', 'application/json' | ||
| settings = AppConfiguration.instance.settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is related to your PR, right? I also don't see it on master, so probably should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…idget' of https://github.com/CitizenLabDotCo/citizenlab into TAN-6031-add-accessibility-setting-to-survey-question-widget
Changelog