TAN-5965 - Survey results refactor #12763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # back/spec/services/surveys/results_generator_spec.rb
Collaborator
|
jamesspeake
commented
Dec 30, 2025
Comment on lines
-468
to
+434
| options.order(:ordering) | ||
| options # options are by default ordered by :ordering from the association |
Contributor
Author
There was a problem hiding this comment.
I've removed .order(:ordering) as by default options are returned in this order. Noticed that having this additional clause results in an additional query for options that are already loaded when this method is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed
Technical