Release 2026-01-07 (3) #12815
Merged
Release 2026-01-07 (3) #12815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align `participation_stats` it with `destroy`
Rename `userId` to `id` to fix cache invalidation
This commit adds validation to prevent banned emails from being used. We used the zrb-43 code for consistency with the domain blacklist validation, which uses zrb-42, even though we don't have a clear explanation for why this value was picked.
Add UI for banning emails when deleting a user: - Toggle to enable email ban on delete - Optional reason input when ban is enabled
Change from query params (?email=...) to path params (/:email) using Rails resources with param: :email. This also fixes TypeScript error where queryParams was incorrectly used with delete action.
Replace manual JSON rendering with proper JSONAPI serializer.
The original goal of storing the original email hash was to make sure that the email stayed ban even if the normalization rules were changed. However, it makes it more complex to reason about the model and introduce other complexities when banning multiple variants of the same address. For the sake of simplicity, we will only store the normalized_email_hash and enforce unicity. The ban! has been reworked to be idempotent and update the reason/banner is a variant has already been banned.
When importing invites through XLSX, inviting a banned email address now stops the import and shows a clear error message.
Display a warning when deleting a user whose email is already banned. The ban toggle is disabled in this case to avoid confusion.
Exclude the `Lint/BinaryOperatorWithIdenticalOperands` cop for spec files to account for the DSL used by rspec-parameterized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.