PredictorEvaluation should support wait_while_executing. #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroenlein
previously approved these changes
Oct 1, 2025
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
Version bump and testing question. Nothing really blocking.
src/citrine/__version__.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "3.25.0" | |||
| __version__ = "3.25.1" | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| __version__ = "3.25.1" | |
| __version__ = "3.25.2" |
| method='GET', | ||
| path=f'/projects/{pec.project_id}/predictor-evaluations/{in_progress_response["id"]}' | ||
| ) | ||
| assert (len(responses) * [expected_call]) == session.calls |
Collaborator
There was a problem hiding this comment.
Are the call counts sufficient to validate? Or should there be validation of some de-serialization behavior?
Collaborator
Author
There was a problem hiding this comment.
The successful deserialization of .get is confirmed elsewhere. This is primarily to ensure predictor evaluations are properly handled by wait_while_executing
anoto-moniz
force-pushed
the
bugfix/predictor-evaluators-polling
branch
from
3f8eeaa to
f2484f8
Compare
anoto-moniz
force-pushed
the
bugfix/predictor-evaluators-polling
branch
from
f2484f8 to
ec2524c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Add support for polling via
wait_while_executingtoPredictorEvaluators.PR Type:
Adherence to team decisions