Skip to content

Conversation

@kroenlein
Copy link
Collaborator

GEMD Python PR

https://citrine.atlassian.net/browse/PNE-6833

Description

This PR addresses some performance issues in the equality routines for object comparison which surfaced when very a large numbers of LinkByUIDs were compared. There should be no functionality changes.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

Copy link
Contributor

@anoto-moniz anoto-moniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me.

@kroenlein kroenlein merged commit b0a0b97 into main Jun 16, 2025
16 checks passed
@kroenlein kroenlein deleted the maintain/improve-equality-performance branch June 16, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants