Drop 3.8 support; add 3.13 testing; drop support for old versions of Pint #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ormatics/gemd-python into maintain/bump-pint-and-python
kroenlein
commented
Jun 30, 2025
| try: # Informal route changed in 0.22 | ||
| from pint.formatting import _FORMATTERS | ||
| formatter = _FORMATTERS["D"] | ||
| formatter = _FORMATTERS["D"] # pragma: no cover |
Collaborator
Author
There was a problem hiding this comment.
This is unreachable with the current library limits, but is reachable for older versions of Pint. Kept to avoid being "breaking" without a major version bump.
kroenlein
commented
Jun 30, 2025
Comment on lines
+3
to
+6
| numpy==1.24.4; python_version<'3.10' | ||
| pandas==2.0.3; python_version<'3.10' | ||
| numpy>=2.0.2,<=2.1.0; python_version>='3.10' | ||
| pandas==2.3.0; python_version>='3.10' |
Collaborator
Author
There was a problem hiding this comment.
There are some unfortunate import errors if we're not careful about numpy/pandas/Pint combinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEMD Python PR
Description
This PR:
PR Type:
Adherence to team decisions