Feature 217 view issue threads without logging in#1505
Open
ashfaq1934 wants to merge 10 commits intoCiviWiki:developfrom
Open
Feature 217 view issue threads without logging in#1505ashfaq1934 wants to merge 10 commits intoCiviWiki:developfrom
ashfaq1934 wants to merge 10 commits intoCiviWiki:developfrom
Conversation
- Created a new view to display the feed - Updated feed template to display threads without having to register an account - Bugfixes for less files not being found in about.html and how_it_works.html - Modified new thread button to direct the user to login if they haven't been aurthenticated
ashfaq1934
commented
May 4, 2023
ashfaq1934
commented
May 4, 2023
Contributor
Author
Contributor
|
Yes, all files should be formatted with ‘black’ |
|
Code Climate has analyzed commit ca4ccfc and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
Author
|
Here's a demo of the changes that have been implemented. Users will be able to create and delete civis. They can view threads but if they attempt to create a civi they will be redirected to the login url, after they login, they'll be redirected back to the thread they viewed. demo_1.mp4I've managed to get the workflow to pass by editing accounts/views.py which satisfied the linter. Let me know if there's anything missing, hope this helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Threads app update
threadsapp templates to Django template syntax #1152