scripts/check-logs.py: Treat empty string values as 'n' for config check #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3e2f19e ("generator: yml: Reset CONFIG_EFI_SBAT_FILE for Fedora configurations") used '=n' to reset a string value to its default due to a limitation in TuxSuite / TuxMake. This causes a mismatch between the value provided and the value in the config, resulting in an error from the config check: ERROR: CONFIG_EFI_SBAT_FILE=n not found in .config! If the value is empty, treat it as 'n' for the sake of this check. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
JustinStitt,
bwendling and
nickdesaulniers
as code owners
JustinStitt
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3e2f19e ("generator: yml: Reset CONFIG_EFI_SBAT_FILE for Fedora configurations") used '=n' to reset a string value to its default due to a limitation in TuxSuite / TuxMake. This causes a mismatch between the value provided and the value in the config, resulting in an error from the config check:
If the value is empty, treat it as 'n' for the sake of this check.