tc_build: llvm: Handle absence of LLVM_ALL_EXPERIMENTAL_TARGETS #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM_ALL_EXPERIMENTAL_TARGETS was introduced in LLVM 17, so we cannot use it for populating experimental targets on versions older than that. Manually populate the experimental targets in that case by using the initial list of experimental targets from the introduction of LLVM_ALL_EXPERIMENTAL_TARGETS and checking that the 'llvm/lib/Target/<target>' folder exists in the provided LLVM source before adding it to the supported targets list. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
bwendling
approved these changes
Jan 23, 2026
msfjarvis
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM_ALL_EXPERIMENTAL_TARGETSwas introduced in LLVM 17, so we cannot use it for populating experimental targets on versions older than that.Manually populate the experimental targets in that case by using the initial list of experimental targets from the introduction of
LLVM_ALL_EXPERIMENTAL_TARGETSand checking that thellvm/lib/Target/<target>folder exists in the provided LLVM source before adding it to the supported targets list.