Skip to content

tc_build: llvm: Handle absence of LLVM_ALL_EXPERIMENTAL_TARGETS #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msfjarvis merged 1 commit into from
Jan 23, 2026
Merged

tc_build: llvm: Handle absence of LLVM_ALL_EXPERIMENTAL_TARGETS #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tc_build/llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,22 @@


def get_all_targets(llvm_folder, experimental=False):
contents = Path(llvm_folder, 'llvm/CMakeLists.txt').read_text(encoding='utf-8')
targets = []

variables = ['LLVM_ALL_TARGETS']
if experimental:
variables.append('LLVM_ALL_EXPERIMENTAL_TARGETS')

contents = Path(llvm_folder, 'llvm/CMakeLists.txt').read_text(encoding='utf-8')
# Introduced by https://github.com/llvm/llvm-project/commit/1908820d6de5004964e85608070e7c869fc81eac in LLVM 17
if 'LLVM_ALL_EXPERIMENTAL_TARGETS' in contents:
variables.append('LLVM_ALL_EXPERIMENTAL_TARGETS')
else:
# Manually populate experimental targets based on list above
possible_experimental_targets = ('ARC', 'CSKY', 'DirectX', 'M68k', 'SPIRV', 'Xtensa')
targets += [
target for target in possible_experimental_targets
if Path(llvm_folder, 'llvm/lib/Target', target).exists()
]

targets = []
for variable in variables:
if not (match := re.search(fr"set\({variable}([\w|\s]+)\)", contents)):
raise RuntimeError(f"Could not find {variables}?")
Expand Down