Merged
Conversation
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…m/Clarifai/clarifai-nodejs into dani/fix-vulnerabilities
….com/Clarifai/clarifai-nodejs into dani/fix-vulnerabilities
DaniAkash
changed the title
This reverts commit bb74554.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions to address vulnerabilities and adjusts integration tests to accommodate changes in application behavior.
- Upgraded packages in package.json (including @vitest/coverage-v8, vitest, and axios) to the latest versions.
- Updated test assertions in app.integration.test.ts and temporarily skipped a multimodal prediction test in model.integration.test.ts.
- Extended test object setup in fromPartialProtobufObject.unit.test.ts with new properties for LicenseType and Model.Source.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/utils/fromPartialProtobufObject.unit.test.ts | Added expected default fields (licenseType, source, creator, versionCount) to test objects. |
| tests/client/model.integration.test.ts | Skipped the multimodal prediction test. |
| tests/client/app.integration.test.ts | Updated the expected length of models from 16 to 15 and commented out an outdated API assertion. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
tests/client/model.integration.test.ts:293
- Consider adding an explanatory comment to clarify why this test is skipped and include a plan for re-enabling it once the underlying issue is resolved.
it.skip("should predict multimodal with image and text", async () => {
tests/client/app.integration.test.ts:166
- Once the API update is complete, please remove the TODO and re-enable the assertion to ensure full test coverage.
// TODO: Uncomment once the API is updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes dependency updates in
package.jsonand adjustments to test cases in the integration test files. The most important changes include upgrading several dependencies, modifying an assertion inapp.integration.test.ts, and skipping a test inmodel.integration.test.ts.Dependency Updates:
package.json: Upgraded@vitest/coverage-v8from^1.3.1to^3.1.2,vitestfrom^1.3.1to^3.1.2, andaxiosfrom^1.6.8to^1.8.2. These updates aim to ensure compatibility with the latest features and fixes. [1] [2]Test Adjustments:
tests/client/app.integration.test.ts: Updated the expected value in the assertion forlist.value?.lengthfrom16to15to align with changes in the application's behavior or data.tests/client/model.integration.test.ts: Skipped the test for predicting multimodal with image and text by changingittoit.skip. This may indicate the test is temporarily disabled due to issues or ongoing changes.