You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Harmon758 , Thanks for your contribution !
It seems like you have opened PR from the fork of main branch. Since our internal tests needs credentials to run, I would request you to create a branch directly from main repo and open a PR. This will fix the tests failing issue.
Thanks !
Feel free to reach out to me anytime.
I'm not sure what you mean. I'm not a member of Clarifai, so it's not possible for me to create a branch on this repository.
Do you want me to put the changes on the master branch of my fork and recreate the PR? because I don't think that would resolve the credentials issue for the tests.
I'm not sure what you mean. I'm not a member of Clarifai, so it's not possible for me to create a branch on this repository. Do you want me to put the changes on the master branch of my fork and recreate the PR? because I don't think that would resolve the credentials issue for the tests.
@Harmon758 Apologies, Yeah you may not be able to create a branch. No worries.
I will take it from here and create a PR on your behalf.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #769
I've kept the
schema==0.7.5constraint for now, as the changelog for 10.3.3 says it was pinned due to breaking changes.