ZS: Make sure to check for if the player is AFK...#838
Open
SpicyCombo wants to merge 1 commit intoClassiCube:masterfrom
Open
ZS: Make sure to check for if the player is AFK...#838SpicyCombo wants to merge 1 commit intoClassiCube:masterfrom
SpicyCombo wants to merge 1 commit intoClassiCube:masterfrom
Conversation
..when considering whether or not they are part of the game.
Author
|
this time without the change of new line endings |
Collaborator
|
What happens if there are 3 players in the game map and one of them is afk, then the round starts and the afk player comes back? I'm a little concerned that the game state might become invalid in some way since you can become afk and stop being afk at any time. For instance, it seems to use your AFK check here void ResetPledges() {
foreach (Player pl in GetPlayers())
{
Get(pl).PledgeSurvive = false;
}
}If a player goes afk during a game, will their pledge not get reset correctly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..when considering whether or not they are part of the game.