Add negotiated microphone streaming support#1
Open
logabell wants to merge 3 commits intoClassicOldSong:masterfrom
Open
Add negotiated microphone streaming support#1logabell wants to merge 3 commits intoClassicOldSong:masterfrom
logabell wants to merge 3 commits intoClassicOldSong:masterfrom
Conversation
ClassicOldSong
requested changes
Mar 20, 2026
| extern uint32_t EncryptionFeaturesRequested; | ||
| extern uint32_t EncryptionFeaturesEnabled; | ||
|
|
||
| #define MIC_PACKET_MAGIC 0x12345678 |
Owner
There was a problem hiding this comment.
The magic is too generic
Please do not use AI to generate random numbers, they tend to fall in several fixed options.
| EncryptionFeaturesEnabled = 0; | ||
|
|
||
| hostSupportsMic = strstr(response.payload, "a=rtpmap:96 opus/48000/1") != NULL || | ||
| strstr(response.payload, "a=rtpmap:96 opus/48000/2") != NULL; |
Owner
There was a problem hiding this comment.
Can user craft an input like this? Like from hostname configuration or something else?
Owner
|
Hey, not sure if you have seen this, there's some review comments added, may you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the microphone transport changes from logabell/moonlight-common-c-mic into Artemis'
moonlight-common-cbase so Android clients can negotiate, encrypt, encode, and send microphone audio to Apollo-compatible hosts.This is intended to pair with ClassicOldSong/Apollo#1428.
Changes
STREAM_CONFIGURATION.enableMicENCFLG_MICROPHONELiSendMicrophoneOpusDataEx()LiIsMicrophoneStreamActive()andLiIsMicrophoneEncryptionEnabled()Source
Ported from these mic commits in my fork:
Working fork branch:
Validation
This branch is exercised by the companion Android client branch and test build: