Skip to content

Add override for WP version check in "General setting"#118

Merged
xxsimoxx merged 6 commits intoClassicPress:masterfrom
xxsimoxx:addoverride
Jul 30, 2025
Merged

Add override for WP version check in "General setting"#118
xxsimoxx merged 6 commits intoClassicPress:masterfrom
xxsimoxx:addoverride

Conversation

@xxsimoxx
Copy link
Member

This adds a Ignore WordPress version checkbox in the General settings.

image

This is an alternative to add_filter( 'classicpress_ignore_wp_version', '__return_true' ); that is still in place.

image

Closes #98 .

@xxsimoxx xxsimoxx requested a review from bahiirwa July 23, 2025 12:28
Copy link
Member

@KTS915 KTS915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change esc_url_raw to sanitize_url, please? The latter is no longer deprecated, and its use avoids an extra function call.

@xxsimoxx
Copy link
Member Author

Could you change esc_url_raw to sanitize_url, please? The latter is no longer deprecated, and its use avoids an extra function call.

image

This is the output of CPCS. Also using Plugin Check (PCP) reports an error (but not the deprecation).

@KTS915
Copy link
Member

KTS915 commented Jul 28, 2025

sanitize_url() was undeprecated in WP 5.9.0.

Copy link
Member

@KTS915 KTS915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxsimoxx xxsimoxx merged commit 62d8c5c into ClassicPress:master Jul 30, 2025
1 check passed
@xxsimoxx xxsimoxx deleted the addoverride branch July 30, 2025 13:56
xxsimoxx added a commit that referenced this pull request Jan 26, 2026
Include changes from #116, #118, #120, #121, #124.

---------

Co-authored-by: xxsimoxx <simone@gieffeedizioni.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add override setting

2 participants