Skip to content

Comply with wpcs#35

Merged
xxsimoxx merged 15 commits intoClassicPress:mainfrom
xxsimoxx:phpcs
May 8, 2025
Merged

Comply with wpcs#35
xxsimoxx merged 15 commits intoClassicPress:mainfrom
xxsimoxx:phpcs

Conversation

@xxsimoxx
Copy link
Member

Comply with wpcs in order to make this plugin ready for an eventual inclusion in core.

@xxsimoxx xxsimoxx requested a review from KTS915 April 24, 2025 15:52
@KTS915
Copy link
Member

KTS915 commented Apr 25, 2025

What's the best way to test this?

@xxsimoxx
Copy link
Member Author

Just perform some operations with the plugin.
phpcbf is not supposed to change code functionality but just code style.
A bug with PHP <8.3 not having json_validate was already spotted but was not introduced in this PR.

Copy link
Member

@KTS915 KTS915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel 100% confident about reviewing this, but I haven't encountered any problems with it so far!

@xxsimoxx xxsimoxx merged commit 85b4572 into ClassicPress:main May 8, 2025
2 checks passed
@xxsimoxx xxsimoxx deleted the phpcs branch May 8, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants