Fix infinite loop in BookmarkListBatchRenderer.sizePages() when there's no space …#170
Open
Monniasza wants to merge 1 commit intoCleanroomMC:cleanroomfrom
Open
Fix infinite loop in BookmarkListBatchRenderer.sizePages() when there's no space …#170Monniasza wants to merge 1 commit intoCleanroomMC:cleanroomfrom
Monniasza wants to merge 1 commit intoCleanroomMC:cleanroomfrom
Conversation
…for any items Addresses Nomi-CEu/Nomi-CEu#1519
Member
|
Possible to add that condition in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for any items
Closes Nomi-CEu/Nomi-CEu#1519
This PR essentially adds deadlock detection by storing previous progress from the method. If it is found that iteration of the outermost loop has not added any slots, is is known that further iterations will not fit any more since the item index is the same.