Open
Conversation
Contributor
|
Seems RFG hardcoded taskRunClient = project.getTasks().register("runClient", RunMinecraftTask.class, Distribution.CLIENT);
final TaskProvider<?> taskJar = project.getTasks().named("jar");
final Configuration runtimeClasspathCfg = project.getConfigurations()
.getByName(JavaPlugin.RUNTIME_CLASSPATH_CONFIGURATION_NAME);
final Configuration compileClasspathCfg = project.getConfigurations()
.getByName(JavaPlugin.COMPILE_CLASSPATH_CONFIGURATION_NAME);
taskRunClient.configure(task -> {
task.setup(project);
task.setGroup(TASK_GROUP_USER);
task.setDescription("Runs the deobfuscated client with your mod");
task.dependsOn(
launcherSources.getClassesTaskName(),
mcTasks.getTaskDownloadVanillaAssets(),
taskPackagePatchedMc,
"jar");
task.getUsername().set(mcExt.getUsername());
task.getUserUUID().set(mcExt.getUserUUID());
task.classpath(taskPackageMcLauncher);
task.classpath(taskPackagePatchedMc);
task.classpath(patchedConfiguration);
task.classpath(taskJar);
task.classpath(runtimeClasspathCfg);
task.getMainClass().set("GradleStart");
});Idk how it managed to work on your machine™, but you should probably replace that with the output files from tasks.withType(JavaExec).named { it.contains('runClient') || it.contains('runServer') }.configureEach {
dependsOn(shadeDowngradedApi)
classpath = classpath - layout.files(jar) + layout.files(shadeDowngradedApi)
}The name check here is mostly for compatibility with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JVMDowngrader provides more feature than Jabel. In addition to modern Java syntax support, JVMDwongrader (JVMDG) will also allow us to use members introduced on modern Java version, e.g.
List.of()and"someStr".lines().This buildscript natively supports running client/server on Java 17 and Java 21, but for the sake of testing, I made some extra effort to apply JVMDG to normal
runClientandrunServertask, allowing you to test Java 8 compatibility without having to build jar and test in production environment.I made some tests, and can confirm
build/runClient/runServeris working for me.Example for
build:Example.javain source file:Example.classin built jar (bogosorter-1.4.11.jar):You can ignore the
@Refand@Stubannotation, they are invisible at runtime