Fix Popup Panel Interaction over JEI Elements #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
approved these changes
Jan 18, 2025
YannickMG
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Jan 26, 2025
(cherry picked from commit 1fc9c37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #64, interaction with popup panels (clicking, scrolling, etc) is impossible. Input priority was set to LOW which is after JEI (NORMAL), making JEI consume the inputs and cancelling the event before mui2 can handle them. this pr sets mui2's input listeners to HIGH, so they run before JEI. i've not observed any immediate issues, but i also didn't spend that much time testing.
It might also be possible to mixin into JEI to prevent cancelling the event when inside an excluded area.
or perhaps only manage popup panels at HIGH priority.