BUG: Hard-coded filename instead of using the provided file parameter#86
Merged
ClementBeal merged 3 commits intoClementBeal:mainfrom Oct 18, 2025
Merged
BUG: Hard-coded filename instead of using the provided file parameter#86ClementBeal merged 3 commits intoClementBeal:mainfrom
ClementBeal merged 3 commits intoClementBeal:mainfrom
Conversation
ClementBeal
approved these changes
Oct 18, 2025
Owner
|
Hi! Thank you for your PR! I'm going to merge it. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// Line 41 - BUG: Hard-coded filename instead of using the provided file parameter File("a_new.mp4").writeAsBytesSync(byteBuilder.toBytes());Current Issues with the Package:
❌ Writes to a hard-coded file "a_new.mp4"
❌ Does not use the file parameter passed into the function
❌ Causes a permission error due to attempting to write in the root directory
//Fixed file.writeAsBytesSync(byteBuilder.toBytes());