Add more features in process view search query#1948
Open
Saphereye wants to merge 9 commits intoClementTsang:mainfrom
Open
Add more features in process view search query#1948Saphereye wants to merge 9 commits intoClementTsang:mainfrom
Saphereye wants to merge 9 commits intoClementTsang:mainfrom
Conversation
added more prefixes for searches fmt clippy clippy2
clippy
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
- Coverage 54.00% 53.90% -0.10%
==========================================
Files 120 119 -1
Lines 16565 16701 +136
==========================================
+ Hits 8946 9003 +57
- Misses 7619 7698 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I think adding these features now is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features
Issue
Closes: #1912
Testing
Distro: Arch Linux (kernel: 6.18.2-arch2-1)
Checklist
cargo fmt)cargo clippy --all -- -D warningscargo testREADME.md, help menu, docs, configs, etc.)Other
I was wondering whether we could refactor the query component to use a lexer+parser architecture. This should make the query language easier to extend in the future.
Edit: Sorry, I hadn’t seen that @80avin wanted to work on the parser (issue #1897). Can I add these features for now if the parser is WIP?