Skip to content

cc-dialog: fix close button positioning #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florian-sanders-cc merged 2 commits into from
Jan 13, 2026
Merged

cc-dialog: fix close button positioning #1642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d5ae6
fix(cc-dialog): make --cc-dialog-padding actually work
florian-sanders-cc Jan 6, 2026
eed38b7
fix(cc-dialog): make close button position responsive on narrow screens
florian-sanders-cc Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/cc-dialog/cc-dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,16 +204,16 @@ export class CcDialog extends LitElement {
border-radius: var(--cc-border-radius-default, 0.25em);
box-shadow: 2px 4px 8px 0 rgb(0 0 0 / 12%);
box-sizing: border-box;
padding: var(--cc-dialog-padding);
padding: var(--cc-dialog-padding, var(--default-dialog-padding));
width: min(var(--cc-dialog-width, 38em), 80%);

--cc-dialog-padding: var(--cc-dialog-padding-xl);
--default-dialog-padding: var(--cc-dialog-padding-xl);
}

/* stylelint-disable-next-line media-feature-range-notation */
@media screen and (max-width: 25em) {
dialog {
--cc-dialog-padding: var(--cc-dialog-padding-sm);
--default-dialog-padding: var(--cc-dialog-padding-sm);
}
}

Expand All @@ -230,6 +230,7 @@ export class CcDialog extends LitElement {

.dialog-close {
--close-btn-size: 2em;
--close-btn-offset: calc(var(--cc-dialog-padding, var(--default-dialog-padding)) / 1.5);

align-items: center;
background: none;
Expand All @@ -244,7 +245,7 @@ export class CcDialog extends LitElement {
margin-top: calc(var(--close-btn-size) * -1);
position: sticky;
top: 0;
transform: translate(2.75em, -2.75em);
transform: translate(var(--close-btn-offset), calc(var(--close-btn-offset) * -1));
width: var(--close-btn-size);
}

Expand Down
Loading