Satisfied clang-tidy

Author: PatrikLundell

src/avatar.cpp

@@ -345,9 +345,9 @@ void avatar::set_active_mission( mission &cur_mission )
     }
 }
 
-void avatar::set_active_point_of_interest( point_of_interest active_point_of_interest )
+void avatar::set_active_point_of_interest( const point_of_interest &active_point_of_interest )
 {
-    for( auto iter : points_of_interest ) {
+    for( const point_of_interest iter : points_of_interest ) {
         // It's really sufficient to only check the position as used...
         if( iter.pos == active_point_of_interest.pos &&
             iter.text == active_point_of_interest.text ) {
@@ -428,7 +428,7 @@ void avatar::remove_active_mission( mission &cur_mission )
     }
 }
 
-void avatar::add_point_of_interest( point_of_interest new_point_of_interest )
+void avatar::add_point_of_interest( const point_of_interest &new_point_of_interest )
 {
     for( point_of_interest &existing_point_of_interest : points_of_interest ) {
         if( new_point_of_interest.pos == existing_point_of_interest.pos ) {

src/avatar.h

@@ -186,7 +186,7 @@ class avatar : public Character
         /**
          * Set which point of interest is active. The point of interest must be listed in @ref points_of_interest.
          */
-        void set_active_point_of_interest( point_of_interest active_point_of_interest );
+        void set_active_point_of_interest( const point_of_interest &active_point_of_interest );
         /**
          * Called when a mission has been assigned to the player.
          */
@@ -206,7 +206,7 @@ class avatar : public Character
         /**
         * Despite the name, this operation also makes an existing point of interest active.
         */
-        void add_point_of_interest( point_of_interest new_point_of_interest );
+        void add_point_of_interest( const point_of_interest &new_point_of_interest );
         void delete_point_of_interest( tripoint_abs_omt pos );
 
         //return avatar diary

src/mission_ui.cpp

@@ -76,7 +76,7 @@ class mission_ui_impl : public cataimgui::window
                                            bool &need_adjust ) const;
         void draw_selected_description( std::vector<mission *> missions, int &selected_mission );
         void draw_selected_description( std::vector<point_of_interest> points_of_interest,
-                                        int &selected_mission );
+                                        const int &selected_mission );
 
         mission_ui_tab_enum selected_tab = mission_ui_tab_enum::ACTIVE;
         mission_ui_tab_enum switch_tab = mission_ui_tab_enum::num_tabs;
@@ -246,7 +246,7 @@ void mission_ui_impl::draw_controls()
             { mission_ui_tab_enum::ACTIVE, translate_marker( "You have no active missions!" ) },
             { mission_ui_tab_enum::COMPLETED, translate_marker( "You haven't completed any missions!" ) },
             { mission_ui_tab_enum::FAILED, translate_marker( "You haven't failed any missions!" ) },
-            {mission_ui_tab_enum::POINTS_OF_INTEREST, translate_marker( "You don't have any points of interest. Add those from the overmap." )}
+            {mission_ui_tab_enum::POINTS_OF_INTEREST, translate_marker( "You don't have any points of interest.  Add those from the overmap." )}
         };
         ImGui::TextWrapped( "%s", nope.at( selected_tab ).c_str() );
         return;
@@ -441,7 +441,7 @@ void mission_ui_impl::draw_selected_description( std::vector<mission *> missions
 }
 
 void mission_ui_impl::draw_selected_description( std::vector<point_of_interest> points_of_interest,
-        int &selected_mission )
+        const int &selected_mission )
 {
     point_of_interest selected_point_of_interest = points_of_interest[selected_mission];
     ImGui::TextWrapped( _( "Point of Interest: %s" ), selected_point_of_interest.text.c_str() );