Merge pull request #82604 from Standing-Storm/star-vampire-invisibility

Star vampires have `PERMANENT_INVISIBILITY`, when they drink blood it applies `SUPPRESS_INVISIBILITY`

Author: Standing-Storm

data/json/effects.json

@@ -5071,8 +5071,8 @@
     "name": [ "Drank blood" ],
     "desc": [ "The star vampire has drunk blood and is now visible." ],
     "rating": "good",
-    "removes_effects": [ "invisibility" ],
-    "show_in_info": true
+    "show_in_info": true,
+    "flags": [ "SUPPRESS_INVISIBILITY" ]
   },
   {
     "id": "star_vampire_blood_drink_feral",

data/json/monster_special_attacks/spells.json

@@ -1119,20 +1119,6 @@
     "flags": [ "SILENT", "NO_EXPLOSION_SFX", "RANDOM_DURATION" ],
     "effect_str": "nausea"
   },
-  {
-    "type": "SPELL",
-    "id": "star_vampire_invisibility_spell",
-    "name": { "str": "star vampire invisibility", "//~": "NO_I18N" },
-    "description": { "str": "Makes the star vampire invisible", "//~": "NO_I18N" },
-    "valid_targets": [ "self" ],
-    "effect": "attack",
-    "effect_str": "invisibility",
-    "shape": "blast",
-    "message": "",
-    "min_duration": 99999999999,
-    "max_duration": 99999999999,
-    "flags": [ "SILENT", "NO_EXPLOSION_SFX", "RANDOM_DURATION" ]
-  },
   {
     "type": "SPELL",
     "id": "sloth_attack",

data/json/monsters/nether.json

@@ -690,15 +690,6 @@
         "miss_msg_npc": "%1$s tries to fasten onto <npcname>, but they dodge!",
         "no_dmg_msg_u": "%1$s tries to fasten onto your %2$s, but can't penetrate your armor.",
         "no_dmg_msg_npc": "%1$s tries to fasten onto <npcname>'s %2$s, but can't penetrate their armor."
-      },
-      {
-        "id": "star_vampire_invisibility",
-        "type": "spell",
-        "spell_data": { "id": "star_vampire_invisibility_spell", "min_level": 3 },
-        "cooldown": 1,
-        "allow_no_target": true,
-        "condition": { "or": [ { "not": { "u_has_effect": "invisibility" } }, { "not": { "u_has_effect": "star_vampire_blood_drank" } } ] },
-        "monster_message": ""
       }
     ],
     "bleed_rate": 40,
@@ -721,7 +712,8 @@
       "PLASTIC",
       "NO_BREATHE",
       "HARDTOSHOOT",
-      "NOGIB"
+      "NOGIB",
+      "PERMANENT_INVISIBILITY"
     ],
     "armor": { "bash": 8, "electric": 3 }
   },
@@ -886,15 +878,6 @@
         "miss_msg_npc": "%1$s tries to clutch onto you <npcname>, but they dodge!",
         "no_dmg_msg_u": "%1$s tries to clutch onto your %2$s, but can't penetrate your armor.",
         "no_dmg_msg_npc": "%1$s tries to clutch onto <npcname>'s %2$s, but can't penetrate their armor."
-      },
-      {
-        "id": "star_vampire_invisibility",
-        "type": "spell",
-        "spell_data": { "id": "star_vampire_invisibility_spell", "min_level": 3 },
-        "cooldown": 1,
-        "allow_no_target": true,
-        "condition": { "or": [ { "not": { "u_has_effect": "invisibility" } }, { "not": { "u_has_effect": "star_vampire_blood_drank" } } ] },
-        "monster_message": ""
       }
     ]
   },