Various clang-demanded fixes

Author: RenechCDDA

src/character.h

@@ -1221,7 +1221,7 @@ class Character : public Creature, public visitable
 
     private:
         double evaluate_weapon_internal( const item &maybe_weapon, bool can_use_gun,
-                                         bool use_silent, const int pretend_ammo = 0 ) const;
+                                         bool use_silent, int pretend_ammo = 0 ) const;
         mutable std::optional<bool> cached_dead_state;
     public:
         void set_part_hp_cur( const bodypart_id &id, int set ) override;

src/npc.h

@@ -1131,7 +1131,6 @@ class npc : public Character
         int evaluate_sleep_spot( tripoint_bub_ms p );
         // Returns true if did something and we should end turn
         bool scan_new_items();
-    public:
         // Returns best weapon. Can return null (fists)
         item *evaluate_best_weapon() const;
         // Returns true if did wield it

src/npcmove.cpp

@@ -4135,9 +4135,6 @@ bool npc::do_player_activity()
 
 item *npc::evaluate_best_weapon() const
 {
-    bool can_use_gun = !is_player_ally() || rules.has_flag( ally_rule::use_guns );
-    bool use_silent = is_player_ally() && rules.has_flag( ally_rule::use_silent );
-
     item_location weapon = get_wielded_item();
     item &weap = weapon ? *weapon : null_item_reference();
 
@@ -4157,7 +4154,7 @@ item *npc::evaluate_best_weapon() const
     }
 
     //Now check through the NPC's inventory for melee weapons, guns, or holstered items
-    visit_items( [this, can_use_gun, use_silent, &weap, &best_value, &best]( item * node, item * ) {
+    visit_items( [this, &weap, &best_value, &best]( item * node, item * ) {
         if( can_wield( *node ).success() ) {
             double weapon_value = 0.0;
             bool using_same_type_bionic_weapon = is_using_bionic_weapon()

src/player_difficulty.cpp

@@ -11,7 +11,6 @@
 #include "character_martial_arts.h"
 #include "inventory.h"
 #include "item.h"
-#include "itype.h"
 #include "mutation.h"
 #include "npc_opinion.h"
 #include "options.h"