fix weighted_int_list iteration (#82859)

Co-authored-by: mqrause <[email protected]>

Author: mqrause

src/character.cpp

@@ -8402,15 +8402,14 @@ void Character::apply_random_wound( bodypart_id bp, const damage_instance &d )
     }
 
     weighted_int_list<wound_type_id> possible_wounds;
-    for( const weighted_object<int, bp_wounds> &wd : bp->potential_wounds ) {
+    for( const std::pair<bp_wounds, int> &wd : bp->potential_wounds ) {
         for( const damage_unit &du : d.damage_units ) {
-            const bool damage_within_limits =
-                du.amount >= wd.obj.damage_required.first &&
-                du.amount <= wd.obj.damage_required.second;
-            const bool damage_type_matches = std::find( wd.obj.damage_type.begin(), wd.obj.damage_type.end(),
-                                             du.type ) != wd.obj.damage_type.end();
+            const bool damage_within_limits = du.amount >= wd.first.damage_required.first &&
+                                              du.amount <= wd.first.damage_required.second;
+            const bool damage_type_matches = std::find( wd.first.damage_type.begin(),
+                                             wd.first.damage_type.end(), du.type ) != wd.first.damage_type.end();
             if( damage_within_limits && damage_type_matches ) {
-                possible_wounds.add( wd.obj.id, wd.weight );
+                possible_wounds.add( wd.first.id, wd.second );
             }
         }
     }

src/medical_ui.cpp

@@ -520,19 +520,19 @@ static medical_column draw_health_summary( const int column_count, Character &yo
 
         if( debug_mode ) {
             detail_str += "All potential wounds:\n";
-            for( const weighted_object<int, bp_wounds> &wd : bp->get_id()->potential_wounds ) {
+            for( const std::pair<bp_wounds, int> &wd : bp->get_id()->potential_wounds ) {
                 std::string damage_types;
 
-                for( const damage_type_id dt : wd.obj.damage_type ) {
+                for( const damage_type_id dt : wd.first.damage_type ) {
                     damage_types += dt.c_str();
                     damage_types += ", ";
                 }
                 damage_types.pop_back();
                 damage_types.pop_back();
                 detail_str +=
                     string_format( "%s:\nweight: %s\ndamage types required: %s\ndamage required: [ %s - %s ]\n",
-                                   colorize( wd.obj.id.c_str(), c_yellow ), wd.weight, damage_types, wd.obj.damage_required.first,
-                                   wd.obj.damage_required.second );
+                                   colorize( wd.first.id.c_str(), c_yellow ), wd.second, damage_types, wd.first.damage_required.first,
+                                   wd.first.damage_required.second );
             }
         }