Skip to content

Conversation

@ehughsbaird
Copy link
Contributor

@ehughsbaird ehughsbaird commented Oct 13, 2025

Summary

Infrastructure "Allowing inverting lake generation for islands-style overmaps"

Purpose of change

A conversation I had with Karol1223 about #83275

Describe the solution

Add an optional bool to lake region settings that inverts the noise function. Also add bounds to the lake flood-fill (similar to the ocean flood-fill) to prevent an infinite loop in lake flood-fill.

Also load the bed/surface/shore/interior terrains from region settings.

Testing

Set invert_lakes to true and generate a world.
A world dominated by lake, with some islands

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 13, 2025
To create archipelago-style maps.
For custom lake generations
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 13, 2025
@Maleclypse Maleclypse merged commit 74aa340 into CleverRaven:master Oct 15, 2025
25 of 29 checks passed
@ehughsbaird ehughsbaird deleted the lakes-forever branch October 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display [Markdown] Markdown issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants