Cc/test lazy level precomputed #3895
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costachris
force-pushed
the
cc/test_lazy_level_precomputed
branch
11 times, most recently
from
a8c308c to
55024cc
Compare
costachris
force-pushed
the
cc/test_lazy_level_precomputed
branch
2 times, most recently
from
36e7a7e to
b557313
Compare
Remove from ᶜρa⁰ Fixed syntax errors Removed ᶜρ⁰ from precomputed Remove ᶜq_tot⁰ (and fix forgotten ᶜρa⁰ Introduced helper functions to compute sums over draft, environmental volumetric variables, and specific env variables Use new helper functions to simplify calculation of ᶜq_tot⁰ Remove redundant draft sum functions Added specific_env_mse helper Removed ᶜmse⁰ from precomputed Remove ᶜq_liq⁰, ᶜq_ice⁰, ᶜq_rai⁰, ᶜq_sno⁰ from precomputed Remove redundant draft sum helper functions; docstrings Added TODO Renamed specific_gs to all_specific_gs; specific_sgs to all_specific_sgs; added docstrings Added new helper specific_sgs to cleanly extract specific SGS quantities; use it to get env TKE Change specific_sgs to use ClimaCore>MatrixFIelds for type stability Removed ᶜspecific (GS precomputed specific quantities); caveat lector [lots of changes] Correcting errors in previous commit removing gs precomputed quantities Removed a few more instances of ᶜspecific from precomputed quantities; removed ᶜtke⁰ Missing ᶜtke⁰ removal Another ᶜtke⁰ fix Introduced helper function for specific_tke and used it where needed Corrections of rebasing mistakes; updates to variable_manipulations for clarity. Removing some more ᶜspecific Added ᶜtke⁰ computations Removal of more specifics Remove h_tot Syntax corrections Fixes in cloud fraction Syntax error fix in jacobian Remove specific in precomputed_quantities; syntax error corrections
costachris
force-pushed
the
cc/test_lazy_level_precomputed
branch
from
88e9fbd to
b4da289
Compare
costachris
force-pushed
the
cc/test_lazy_level_precomputed
branch
3 times, most recently
from
ea18827 to
0bcdc6d
Compare
costachris
force-pushed
the
cc/test_lazy_level_precomputed
branch
from
0bcdc6d to
6513652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Content