Skip to content

Conversation

imreddyTeja
Copy link
Member

@imreddyTeja imreddyTeja commented Aug 8, 2025

Make a patch release


  • I have read and checked the items on the review checklist.

@@ -1,17 +1,18 @@
# This file is machine-generated - editing it directly is not advised

julia_version = "1.10.5"
julia_version = "1.11.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know these manifests existed - I assume they didn't need to use Julia 1.10 but they're just old, so this is probably fine

@szy21
Copy link
Member

szy21 commented Aug 8, 2025

Thanks! Do you plan to update the latest versions of the packages too?

@imreddyTeja
Copy link
Member Author

Thanks! Do you plan to update the latest versions of the packages too?

I'm not sure I understand. The latest versions of which packages?

@imreddyTeja
Copy link
Member Author

@szy21 I think using a newer version of RootSolvers.jl is causing the reproducibility tests to fail. Should the tables be updated?

@szy21
Copy link
Member

szy21 commented Aug 8, 2025

Thanks! Do you plan to update the latest versions of the packages too?

I'm not sure I understand. The latest versions of which packages?

New minor versions of climaparams and thermodynamics.

@szy21
Copy link
Member

szy21 commented Aug 8, 2025

@szy21 I think using a newer version of RootSolvers.jl is causing the reproducibility tests to fail. Should the tables be updated?

Yes, just increase the ref counter.

@imreddyTeja
Copy link
Member Author

Thanks! Do you plan to update the latest versions of the packages too?

I'm not sure I understand. The latest versions of which packages?

New minor versions of climaparams and thermodynamics.

I can't update them because their version is restricted by SurfaceFluxes and Insolation. I could add them to the compat if you'd like, but they would be untested.

@juliasloan25
Copy link
Member

juliasloan25 commented Aug 8, 2025

This is my bad - @szy21 when I said we'd update the versions of ClimaParams and TD I didn't realize they need to get updated in Insolation and SF first. Would you rather update those as well (and move this atmos release to tomorrow), or make this release now and update those packages + release next week?

I do think it would be helpful to release atmos today since it's been causing downstream coupler tests to fail in ClimaLand

@imreddyTeja
Copy link
Member Author

I think Tapio may have also wanted Atmos to use RootSolvers v1.0.0, but that also needs a ClimaCore release.

@szy21
Copy link
Member

szy21 commented Aug 8, 2025

This is my bad - @szy21 when I said we'd update the versions of ClimaParams and TD I didn't realize they need to get updated in Insolation and SF first. Would you rather update those as well (and move this atmos release to tomorrow), or make this release now and update those packages + release next week?

I do think it would be helpful to release atmos today since it's been causing downstream coupler tests to fail in ClimaLand

Sure, feel free to make a release now. It would be good to update those packages as soon as possible though. Some of us may be able to help update different repos.

ClimaDiagnostics = "0.2.12"
ClimaInterpolations = "0.1.0"
ClimaParams = "0.10.35"
ClimaParams = "0.10.35, 0.11"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szy21 should support for the older versions be dropped, or is what I have here OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the values of some parameters changed but names didn't change so the interface hasn't changed. So it should be fine to continue allowing 0.10 and 0.11. But Zhaoyi will know for sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, what you have here is ok.

@imreddyTeja imreddyTeja added this pull request to the merge queue Aug 9, 2025
Merged via the queue into main with commit 7819ddd Aug 9, 2025
19 checks passed
@imreddyTeja imreddyTeja deleted the tr/bump branch August 9, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants