-
Notifications
You must be signed in to change notification settings - Fork 24
Bump to v0.31.1 #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.31.1 #3933
Conversation
@@ -1,17 +1,18 @@ | |||
# This file is machine-generated - editing it directly is not advised | |||
|
|||
julia_version = "1.10.5" | |||
julia_version = "1.11.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even know these manifests existed - I assume they didn't need to use Julia 1.10 but they're just old, so this is probably fine
Thanks! Do you plan to update the latest versions of the packages too? |
I'm not sure I understand. The latest versions of which packages? |
@szy21 I think using a newer version of RootSolvers.jl is causing the reproducibility tests to fail. Should the tables be updated? |
New minor versions of climaparams and thermodynamics. |
Yes, just increase the ref counter. |
I can't update them because their version is restricted by SurfaceFluxes and Insolation. I could add them to the compat if you'd like, but they would be untested. |
This is my bad - @szy21 when I said we'd update the versions of ClimaParams and TD I didn't realize they need to get updated in Insolation and SF first. Would you rather update those as well (and move this atmos release to tomorrow), or make this release now and update those packages + release next week? I do think it would be helpful to release atmos today since it's been causing downstream coupler tests to fail in ClimaLand |
I think Tapio may have also wanted Atmos to use RootSolvers v1.0.0, but that also needs a ClimaCore release. |
Sure, feel free to make a release now. It would be good to update those packages as soon as possible though. Some of us may be able to help update different repos. |
ClimaDiagnostics = "0.2.12" | ||
ClimaInterpolations = "0.1.0" | ||
ClimaParams = "0.10.35" | ||
ClimaParams = "0.10.35, 0.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szy21 should support for the older versions be dropped, or is what I have here OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the values of some parameters changed but names didn't change so the interface hasn't changed. So it should be fine to continue allowing 0.10 and 0.11. But Zhaoyi will know for sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, what you have here is ok.
Make a patch release