Skip to content

Reorder make_plots for EDMFSpherePlots and make comparison plot column widths equal #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .buildkite/ci_driver.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
# (See also Base.type_limited_string_from_context())
redirect_stderr(IOContext(stderr, :stacktrace_types_limited => Ref(false)))
# PrecompileCI is a local package that forces commonly used methods to be precompiled,
# allowing them to be reused between Julia sessions.
# To load in the precompiled methods, run `using PrecompileCI` before loading ClimaAtmos.
# allowing them to be reused between Julia sessions.
# To load in the precompiled methods, run `using PrecompileCI` before loading ClimaAtmos.
# To see what methods are precompiled, open julia: `julia --project=.buildkite/PrecompileCI`
# and run `using PrecompileTools; PrecompileTools.verbose[] = true; include(".buildkite/PrecompileCI/src/PrecompileCI.jl")`
using PrecompileCI
Expand Down
23 changes: 9 additions & 14 deletions post_processing/ci_plots.jl
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ function make_plots_generic(
normalized_path =
lpad(path, LABEL_LENGTH + 1, " ")[(end - LABEL_LENGTH):end]

CairoMakie.Label(fig[0, col], path)
CairoMakie.Label(fig[0, col], normalized_path)
end
end
return fig
Expand Down Expand Up @@ -1606,25 +1606,20 @@ function make_plots(::EDMFSpherePlots, output_paths::Vector{<:AbstractString})

short_name_tuples = pair_edmf_names(short_names)

# The hierarchy is:
# - A vector looping over variables
# - Containing, a vector looping over latitudes
# - Containing, tuples with one or two variables
# - Repeated for each simdir
# All of this is flattened out to be a vector of tuples (with the two gridmean/updraft
# variables)
# Create a flat sequence of variable groups iterating over variable,
# latitude, and simulation directory
var_groups_zt = vcat(
map_comparison(simdirs, short_name_tuples) do simdir, name_tuple
return [
(
[
map_comparison(simdirs, latitudes) do simdir, lat
return (
slice(
get(simdir; short_name, reduction, period),
lon = 0.0,
lat = lat,
) for short_name in name_tuple
) for lat in latitudes
]
end...,
)
end for name_tuple in short_name_tuples
]...,
)

var_groups_z = [
Expand Down
Loading