Skip to content

Reorder make_plots for EDMFSpherePlots and make comparison plot column widths equal #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

petebachant
Copy link
Member

@petebachant petebachant commented Aug 11, 2025

Purpose

Resolves #3915

To-do

  • Maybe don't use a comprehension to create var_groups_zt, because it's confusing?

Content

summary_comparison.pdf files will now look like:

image
  • I have read and checked the items on the review checklist.

@petebachant
Copy link
Member Author

Looking at the buildkite artifacts, the page width seems to be narrower for these than the other two-column plots:

image

@petebachant petebachant force-pushed the fix-ci-plot-align branch 2 times, most recently from 1a48cf9 to fd0b8ec Compare August 12, 2025 18:22
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @szy21 or @trontrytel could take a look as well, but the plots and changes look good to me.

@trontrytel
Copy link
Member

This is awesome. Thank you so much!

@nefrathenrici
Copy link
Member

Could you squash your commits and add this to the merge queue?

@szy21
Copy link
Member

szy21 commented Aug 12, 2025

Thank you!

@petebachant petebachant enabled auto-merge August 12, 2025 21:45
@petebachant petebachant added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit 714ff9e Aug 13, 2025
17 of 19 checks passed
@petebachant petebachant deleted the fix-ci-plot-align branch August 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison plots are not aligned
4 participants