Skip to content

Add Rainwater Path Diagnostic #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add Rainwater Path Diagnostic #3946

wants to merge 15 commits into from

Conversation

erphamucsd
Copy link

@erphamucsd erphamucsd commented Aug 12, 2025

Purpose

Implementing rainwater path as a diagnostic variable.

To-do

Content

  • Implemented RWP in core_diagnostics.jl.
  • Add as a diagnostic for "config/model_configs/prognostic_edmfx_dycoms_rf02_column.yml".

  • I have read and checked the items on the review checklist.

@erphamucsd
Copy link
Author

Closed and reopened because the branch was renamed to better fit the naming convention. Suggestions from previous PR have been added/committed to this branch.

@erphamucsd erphamucsd marked this pull request as ready for review August 12, 2025 20:40
short_name = "rwp",
long_name = "Rainwater Path",
standard_name = "atmosphere_mass_content_of_rain_liquid_water",
units = "kg m-2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units = "kg m-2",
units = "kg m^-2",

@akshaysridhar
Copy link
Member

akshaysridhar commented Aug 12, 2025

Closed and reopened because the branch was renamed to better fit the naming convention. Suggestions from previous PR have been added/committed to this branch.

@erphamucsd On the TODO block above : the pattern moving forward will rely on reducing dependency on cache variables - so, instead of precomputing q_rai we will use the specific function if necessary to get quantities from prognostic state variables. LazyBroadcast may also help with faster gpu code; you're using scratch space here so this is not strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants