-
Notifications
You must be signed in to change notification settings - Fork 26
Update benchmark_step.jl for CUDA benchmarking with useful kernel names
#4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
petebachant
wants to merge
42
commits into
main
Choose a base branch
from
pb/gpu-perf-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
abe1f57
Update benchmark_step.jl for CUDA profiling
petebachant cbad8ac
Fix external profiler determination
petebachant df5f349
Get kernel naming option from ClimaCore
petebachant 606f584
Control kernel naming via env var
petebachant f369d6c
Use dev version of ClimaCore
petebachant e4ce7a2
Short-circuit GPU benchmark based on device
petebachant a521070
Rename kernels in buildkite
petebachant 04e0454
Autoformat .buildkite/pipeline.yml
petebachant 8a931f5
Improve logging
petebachant 215255f
Always import CUDA
petebachant 0b362e7
Name kernels from stack trace in benchmark GPU default
petebachant cba2694
Merge branch 'main' of https://github.com/CliMA/ClimaAtmos.jl into pb…
petebachant 6620982
Set stacktrace-based kernel names before compiling
petebachant 3dcca85
Print internal profling result in benchmark_step.jl
petebachant b228a35
Relocate function so it can be called
petebachant 4439d43
Update ClimaCore dev dep
petebachant f36f405
Update ClimaCore
petebachant a09bbc0
Trigger build
petebachant 317dca8
Merge main
petebachant 1153ca3
Fix url
petebachant 7aa7dea
Widen display size for CUDA profiling results
petebachant f4429ff
Narrow print
petebachant 57fba6c
Remove limit
petebachant b073672
Update ClimaCore
petebachant 3824cde
Merge branch 'main' of github.com:CliMA/ClimaAtmos.jl into pb/gpu-perf-2
petebachant cb6bc31
Update ClimaCore
petebachant e41ea59
Merge main
petebachant efb94cf
Update ClimaCore
petebachant ac635a4
Merge branch 'main' of https://github.com/CliMA/ClimaAtmos.jl into pb…
petebachant 90ccf5b
Move CUDA kernel naming selection via env var into ClimaCore
petebachant 63e213d
Update ClimaCore
petebachant 512471e
Set kernel naming from stack trace enabled for entire buildkite pipeline
petebachant 175164c
Update ClimaCore
petebachant 7dd4645
Update ClimaCore
petebachant 88cc058
Merge branch 'main' of https://github.com/CliMA/ClimaAtmos.jl into pb…
petebachant 7e959cd
Update ClimaCore
petebachant 77ef5e8
Update ClimaCore and only rename kernels in specific benchmarks
petebachant d7befca
Update ClimaAtmos
petebachant 5559604
Update ClimaCore
petebachant adde261
Update comment
petebachant 427b8db
Update comment
petebachant ad20c71
Revert "Update comment"
petebachant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were made by a YAML auto-formatter in VS Code. Is there a style guide I might be breaking here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure... this is something I have been wondering as well. I considered following this example, which is used in Buildkite's docs.