GW drag parametrization #4208
Draft
GW drag parametrization #4208
+6,169
−1,483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray-chew
force-pushed
the
rc/ogwd_gpu
branch
4 times, most recently
from
5ad4401 to
ec67555
Compare
- Refactored OGW code for GPU compatibility (no allocations on GPU) - Added ClimaParams integration for tunable parameters - Added OGW and NOGW modules to callbacks (controlled by dt_ogw and dt_nogw parameters) - Added topography preprocessing pipeline
- Migrated single column, 3D, and MIMA tests to use ClimaAtmos infrastructure - Tests now use ClimaParams for parameters
- Added Garner 2005 figure reproduction tests - Added OGW baseflux and computed drag tests - Added topography preprocessing utilities - Removed old ogwd_3d.jl and ogwd_baseflux.jl (replaced with new tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ororgraphic gravity-wave parameterization is throwing NaNs with ClimaLand 1.3.0. I will debug this after AMS.
Purpose
To-do
Content