Add support for linear indexing for pointwise kernels #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/linear_indexing_pointwise
branch
6 times, most recently
from
4788cf4 to
9d5f538
Compare
Merged
charleskawczynski
force-pushed
the
ck/linear_indexing_pointwise
branch
7 times, most recently
from
c470885 to
6cce85f
Compare
charleskawczynski
force-pushed
the
ck/linear_indexing_pointwise
branch
from
6cce85f to
378bbcf
Compare
Member
Author
|
Just to leave some breadcrumbs here: This is basically what Tim resorted to in JuliaGPU/GPUArrays.jl#520. We can't really do this unless we either drop the field dimension, or move the field dimension to the end (e.g., I think that moving the field dimension to the end is probably the most ideal solution, but it is a breaking change (unless we add support for a whole new set of datalayouts). |
Merged
Member
Author
|
Superseded by #2055. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends / supersedes #1919. Depends on #1920.