Define FiniteDifferenceSpace for extruded spaces #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/FiniteDifferenceSpace_constr
branch
from
85b7f32 to
ab09e0a
Compare
|
I don't this is controversial, so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure here revealed that ClimaDiagnostics.jl is reconstructing the vertical grid, via
_FiniteDifferenceGrid, which is not efficient (we can instead just return a pointer) and will become gpu-incompatible in #2343 (as the mesh, once made, will be moved to the gpu).This PR defines
FiniteDifferenceSpace(space::ExtrudedFiniteDifferenceSpace)which avoids that code path and reconstructs a new grid with the same backing data.I suppose I should add this to ClimaDiagnostics, so that I can test it in ClimaAtmos, as this is the only place where this functionality seems to be exercised. I'll do that now, but this feature should probably exist in ClimaCore.