Added remapping to ClimaCorePlots #2361
Open
+55
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might be useful for debugging in an infiltrator session
| xguide --> "panel x1" | ||
| yguide --> "panel x2" | ||
| seriescolor --> :balance | ||
| # @Main.infiltrate |
There was a problem hiding this comment.
Suggested change
| # @Main.infiltrate |
|
|
||
| (unfolded_panels) | ||
| # hcoords = Remapping.default_target_hcoords(axes(field)) |
There was a problem hiding this comment.
Suggested change
| # hcoords = Remapping.default_target_hcoords(axes(field)) |
| seriescolor --> :balance | ||
| title --> "Lat-Lon Remapped Field ($nlat × $nlon)" | ||
|
|
||
| return (longpts, latpts, transpose(remapped)) |
There was a problem hiding this comment.
Could you please include an example of the output from your suggested changes and differentiate it from the default "unfolded panel" output in the docs for ClimaCorePlots (I realise the current doc section for Libraries > ClimaCorePlots.jl is empty..) . Thanks @ray-chew, this way we can visually inspect the different options available here. It seems the current tests https://github.com/CliMA/ClimaCore.jl/blob/main/lib/ClimaCorePlots/test/runtests.jl rely heavily on png generation with isfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature might be useful for debugging in an infiltrator session.