-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for FiniteDifferenceSpaces #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2478b5d to
3b7e689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few suggestions for reducing code duplication, and it would be good to test all of this by adding column fields to loops over extruded fields in the test suite.
src/Operators/spectralelement.jl
Outdated
| Gradient{()}, | ||
| WeakGradient{()}, | ||
| Curl{()}, | ||
| WeakCurl{()}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put SpectralOperator type or find subtype
3bc6f35 to
198c602
Compare
45a3d65 to
06de797
Compare
81f57d5 to
d3f5b12
Compare
This PR enables horizontal spectral element operators (gradient, divergence, curl) to work correctly on column spaces extracted from hybrid spaces, returning appropriate zero values since columns have no horizontal dimensions.