Tr/vertical mass borrowing limiter #2383
Draft
+2,724
−2,049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Update src/Limiters/vertical_mass_borrowing_limiter.jl Co-authored-by: Tapio Schneider <[email protected]> Use density-dz for pressure thickness
Add gpu support for vertical mass limiter. This addition needs documentation, and also needs to be made more similar to the cpu version. Other fixes: Correct plotting axis Important TODOS: I think the indexing is actually happening bottom to top... Ask about \geq q_min or < qmin Ask about tolerances in the test Probably a good idea to check performance. I suspect this implementation will have poor performance at h_elem < 30
imreddyTeja
force-pushed
the
tr/vertical-mass-borrowing-limiter
branch
from
8ff8caa to
8191082
Compare
imreddyTeja
force-pushed
the
tr/vertical-mass-borrowing-limiter
branch
from
8191082 to
1d18d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gpu support for vertical mass limiter.
This addition needs documentation, and also needs
to be made more similar to the cpu version.
Other fixes:
Correct plotting axis
Important TODOS:
I think the indexing is actually happening bottom to top...
Ask about \geq q_min or < qmin
Ask about tolerances in the test
Probably a good idea to check performance. I suspect this
implementation will have poor performance at h_elem < 30