Skip to content

Ensure CommonGrids uses space filling curve#2429

Merged
nefrathenrici merged 1 commit intomainfrom
ne/fix
Jan 22, 2026
Merged

Ensure CommonGrids uses space filling curve#2429
nefrathenrici merged 1 commit intomainfrom
ne/fix

Conversation

@nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jan 20, 2026

This PR:

  • ensures the CommonGrids use the space filling curve where applicable
  • Adds a function Topology.uses_spacefillingcurve(topology) to test if a space uses a space filling curve
  • Add tests to ensure CommonGrids, cubed sphere, and rectangular mesh all use the space filling curve.

@nefrathenrici nefrathenrici changed the title wip Ensure CommonGrids uses space filling curve Jan 20, 2026
@nefrathenrici nefrathenrici marked this pull request as ready for review January 20, 2026 18:01
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For the release do we want to wait for the Makie update?

@haakon-e
Copy link
Member

haakon-e commented Jan 20, 2026

Thanks! Note that I'm getting some reproducibility failures on the ClimaAtmos side in CliMA/ClimaAtmos.jl#4220 [buildkite] (trying to rerun now to see if it persists)

@nefrathenrici nefrathenrici force-pushed the ne/fix branch 4 times, most recently from 8d82187 to 86e3432 Compare January 21, 2026 19:38
@nefrathenrici nefrathenrici enabled auto-merge (squash) January 22, 2026 22:51
@nefrathenrici nefrathenrici merged commit 3cdb6de into main Jan 22, 2026
36 checks passed
@nefrathenrici nefrathenrici deleted the ne/fix branch January 22, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants