Make ClimaCoreMakie release with bumped Makie compat#2431
Merged
imreddyTeja merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
Update Makie example sphere
szy21
approved these changes
Jan 20, 2026
Member
szy21
left a comment
szy21
left a comment
There was a problem hiding this comment.
Looks good to me. I'm not sure if I'm the best person to review this though.
ph-kev
approved these changes
Jan 20, 2026
Comment on lines
8
to
9
| ClimaCore = "0.11, 0.12, 0.13, 0.14" | ||
| Makie = "0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21" | ||
| Makie = "0.24" | ||
| julia = "1.7" |
Member
There was a problem hiding this comment.
I remembered trying to use Makie 0.24 in the past with older versions of Julia (<= 1.11.x) and it not working. Is this still the case or not?
Member
There was a problem hiding this comment.
In the Project in Makie v0.24, the julia compat is 1.10 so it should be okay, but I haven't tried it
Comment on lines
+43
to
+44
| vertices = plot_vertices(space, coords) | ||
| triangles = plot_triangles(space) |
Member
There was a problem hiding this comment.
What is that reason for not using lift here?
Member
Author
There was a problem hiding this comment.
I believe the new version of Makie uses ComputeGraphs over observables,
juliasloan25
approved these changes
Jan 20, 2026
Member
juliasloan25
left a comment
juliasloan25
left a comment
There was a problem hiding this comment.
Thanks Teja! Just a couple comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Makie compat to 0.24. Drop support for older versions due to breaking changes.
With some extra effort, we could probably add backwards support
Update to use Makie ComputePipelines