Skip to content

Delete .gitmodules#2442

Merged
ph-kev merged 1 commit intomainfrom
kp/remove-submodule
Jan 31, 2026
Merged

Delete .gitmodules#2442
ph-kev merged 1 commit intomainfrom
kp/remove-submodule

Conversation

@ph-kev
Copy link
Member

@ph-kev ph-kev commented Jan 31, 2026

This is an empty file that should be deleted. It is causing problems with Pkg.add.

(.buildkite) pkg> add ClimaCore#kp/pfull
    Updating git-repo `https://github.com/CliMA/ClimaCore.jl.git`
ERROR: GitError(Code:ERROR, Class:Submodule, cannot get submodules without a working tree)

Edit: This isn't causing the problem. I haven't rebase from main, but this is an empty file that should be removed.

@ph-kev ph-kev requested a review from petebachant January 31, 2026 00:48
Copy link
Member

@petebachant petebachant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that Julia complains since it's an empty file, but LGTM!

@ph-kev
Copy link
Member Author

ph-kev commented Jan 31, 2026

Strange that Julia complains since it's an empty file, but LGTM!

I haven't rebase from main, so that was the issue. I still think we should remove it, since it is an empty file.

@ph-kev ph-kev enabled auto-merge (rebase) January 31, 2026 00:52
@ph-kev ph-kev merged commit 78080ac into main Jan 31, 2026
36 checks passed
@ph-kev ph-kev deleted the kp/remove-submodule branch January 31, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants