update land energy/water conservation functions #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/conservation
branch
from
2bf196d to
c3fcb2c
Compare
kmdeck
reviewed
May 9, 2025
| function Interfacer.get_field(sim::ClimaLandSimulation, ::Val{:energy}, level) | ||
| surface_field = similar(sim.integrator.p.soil.sfc_scratch) | ||
| return sum( | ||
| CL.total_energy_per_area!( |
There was a problem hiding this comment.
I think we need to call total_energy_per_area! and then call sum(surface_field) and return that, since CL.total_energy_per_area! returns nothing
since the similar function allocates, is there another surface field we can use?
kmdeck
reviewed
May 9, 2025
| function Interfacer.get_field(sim::ClimaLandSimulation, ::Val{:water}, level) | ||
| surface_field = similar(sim.integrator.p.soil.sfc_scratch) | ||
| return sum( | ||
| CL.total_liq_water_vol_per_area!( |
There was a problem hiding this comment.
and one other thought is that we will need to multiply by density here or somewhere else to get mass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update integrated land conservation functions to use the ClimaLand functions introduced in CliMA/ClimaLand.jl#1071. Note that these provide the energy and water per area, so we integrate horizontally via
sum