remove bucket get_new_cache #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
requested review from
imreddyTeja
and removed request for
imreddyTeja
imreddyTeja
reviewed
Jul 15, 2025
juliasloan25
force-pushed
the
js/cache
branch
2 times, most recently
from
6cfb030 to
e5cc24d
Compare
imreddyTeja
approved these changes
Jul 15, 2025
I'm not sure, but I think it's because we always store water as a volumetric fraction in ClimaLand so we're keeping it consistent there and we only convert to kg/m3 in the coupler where it's used that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the bucket
get_new_cachefunction, and instead access the cached fields for total energy and water directly, which were added in CliMA/ClimaLand.jl#1104.closes #1261