Skip to content

Conversation

@szy21
Copy link
Member

@szy21 szy21 commented Jan 7, 2026

Purpose

Use the new interface in SurfaceFluxes v0.15 to calculate surface fluxes. For the bucket simulation, call the turbulent_fluxes! in ClimaLand directly. Also updates dependencies.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/cc/surface_flux branch 5 times, most recently from acbfc8c to db01989 Compare January 8, 2026 06:46
@simone-silvestri
Copy link
Contributor

Is this PR going to allow using a skin temperature?

@szy21
Copy link
Member Author

szy21 commented Jan 8, 2026

Is this PR going to allow using a skin temperature?

I think we will mimimal changes in this PR to recover the current behavior of the coupler, as we want to merge this relatively fast. But we can allow using a skin temperature now. I want to do it in a separate PR.

@szy21 szy21 force-pushed the zs/cc/surface_flux branch 9 times, most recently from 4176cdc to beabf31 Compare January 14, 2026 21:15
@szy21 szy21 marked this pull request as ready for review January 14, 2026 21:42
@szy21 szy21 force-pushed the zs/cc/surface_flux branch from beabf31 to 5bac863 Compare January 14, 2026 21:52
@szy21 szy21 requested a review from kmdeck January 14, 2026 23:36
@szy21 szy21 force-pushed the zs/cc/surface_flux branch from e0dfe48 to 543d5a9 Compare January 15, 2026 02:12
@szy21 szy21 force-pushed the zs/cc/surface_flux branch 7 times, most recently from fd68206 to 7224a10 Compare January 16, 2026 01:38
@szy21 szy21 force-pushed the zs/cc/surface_flux branch 4 times, most recently from 46a1d70 to 2c5b4bd Compare January 16, 2026 05:47
@szy21
Copy link
Member Author

szy21 commented Jan 16, 2026

working amip: https://buildkite.com/clima/climacoupler-coarse-nightly-amip/builds/763

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src changes look reasonable to me! One thought is we might want to merge this after we resolve the nightly AMIP compat troubles, and figure out why it started failing with the larger coupling timestep

Comment on lines +156 to +147
F_turb_ρτxz = ρτxz,
F_turb_ρτyz = ρτyz,
F_sh = shf,
F_lh = lhf,
F_turb_moisture = evaporation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename these all to use the same variable names as SurfaceFluxes? Especially for F_turb_moisture -> evaporation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that. I guess it depends on whether the coupler wants some convention of variable names - e.g. we have F_turb_energy and F_turb_moisture. It will change many files though - maybe we can do it in a separate PR?

@szy21
Copy link
Member Author

szy21 commented Jan 17, 2026

The src changes look reasonable to me! One thought is we might want to merge this after we resolve the nightly AMIP compat troubles, and figure out why it started failing with the larger coupling timestep

I was thinking about merging this: CliMA/ClimaAtmos.jl#4198 soon, as we want to merge it before working on another breaking change on thermodynamics in ClimaAtmos (and ClimaLand and ClimaCoupler). But it will break nightly AMIP. I can make a patch release of ClimaAtmos now, and a breaking release with the ClimaAtmos PR, so we can resolve the nightly AMIP compat with the patch release of ClimaAtmos?

I'm not too worried about the larger coupling timestep, but am happy to wait for a few days. Kat and I were not sure it's correct for integrated land - e.g. if the land timestep is 8 minutes and coupling timestep is 32 minutes, does the atmosphere get the flux at the end of the four land timesteps? This will cause some significant errors in energy conservation, although I don't know whether it will make things more unstable.

@szy21
Copy link
Member Author

szy21 commented Jan 18, 2026

Actually, amip breaks this week. I'm leaning towards there might be some issue with ClimaLand v1.3. Let's talk next week about how to move forward?

@szy21 szy21 force-pushed the zs/cc/surface_flux branch 4 times, most recently from 6e66394 to 9f2c696 Compare January 22, 2026 00:31
@juliasloan25
Copy link
Member

Dependency updates in this PR:

  [13f3f980] ↑ CairoMakie v0.12.18 ⇒ v0.15.8
  [b2c96348] ~ ClimaAtmos v0.33.2 ⇒ v0.34.0
  [d414da3d] ↑ ClimaCore v0.14.45 ⇒ v0.14.46
  [908f55d8] ↑ ClimaCoreMakie v0.4.6 ⇒ v0.4.7
  [08f4d4ce] ~ ClimaLand v1.3.0 ⇒ v1.4.0
  [5c42b081] ↑ ClimaParams v1.0.9 ⇒ v1.0.10
⌃ [6ba0ff68] ↑ ClimaSeaIce v0.3.10 ⇒ v0.3.12
  [aa8a2aa5] ↑ EnsembleKalmanProcesses v2.6.0 ⇒ v2.6.1
  [db073c08] ↑ GeoMakie v0.7.12 ⇒ v0.7.16
  [ee78f7c6] ↑ Makie v0.21.18 ⇒ v0.24.8
⌃ [9e8cae18] ↑ Oceananigans v0.100.7 ⇒ v0.103.1

@juliasloan25
Copy link
Member

CMIP runs out of GPU parameter memory on the P100s with this Oceananigans update. It still runs fine on A100s. I'll make the CI runs soft fail so we can at least continue working on AMIP while we figure out a solution for CMIP.

See CliMA/Oceananigans.jl#5191

@szy21 szy21 force-pushed the zs/cc/surface_flux branch from 1b71ca4 to c249297 Compare January 23, 2026 00:22
@szy21 szy21 changed the title update surface fluxes update surface fluxes and update dependencies Jan 23, 2026
@szy21 szy21 force-pushed the zs/cc/surface_flux branch from c249297 to 2b45037 Compare January 23, 2026 00:26
@szy21 szy21 force-pushed the zs/cc/surface_flux branch from 2b45037 to 2889878 Compare January 23, 2026 00:26
@szy21 szy21 enabled auto-merge January 23, 2026 01:00
@szy21 szy21 merged commit 138d48a into main Jan 23, 2026
16 checks passed
@szy21 szy21 deleted the zs/cc/surface_flux branch January 23, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants