Skip to content

fixed scalarIndexing performance issue #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fixed scalarIndexing performance issue #1215

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb26418
fixed scalarIndexing performance issue
riteshbhirud Jul 8, 2025
04a3d05
reduced allocations for NaNs
riteshbhirud Jul 8, 2025
da7e61f
run_formatter
riteshbhirud Jul 22, 2025
3aa4e66
Merge branch 'CliMA:main' into main
riteshbhirud Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/shared_utilities/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,22 +593,23 @@ function count_nans_state(
mask = nothing,
verbose = false,
)
# Note: this code uses `parent`; this pattern should not be replicated
num_nans = 0
ClimaComms.allowscalar(ClimaComms.device()) do
num_nans =
isnothing(mask) ? Int(sum(isnan.(parent(state)))) :
Int(sum(isnan.(parent(state)) .* parent(mask)))
end
if isapprox(num_nans, 0)
if isnothing(mask)
num_nans = count(isnan, parent(state))
else
num_nans = mapreduce(
(s, m) -> m != 0 && isnan(s),
Base.add_sum,
parent(state),
parent(mask)
)
end
if num_nans == 0
verbose && @info "No NaNs found"
else
@warn "$num_nans NaNs found"
end
return nothing
end


"""
NaNCheckCallback(nancheck_frequency::Union{AbstractFloat, Dates.Period},
start_date, dt)
Expand Down
Loading